Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing node-resize test to add a sleep #38324

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Fixing node-resize test to add a sleep #38324

merged 1 commit into from
Dec 7, 2016

Conversation

foxish
Copy link
Contributor

@foxish foxish commented Dec 7, 2016 •
edited

This fix is for the 1.4 branch.
It fixes #38231

This makes the 1.5 upgrade tests green while being a NOP on
the older 1.4 tests.

  • pre-1.5 behavior is that the NC cleans up pods as soon as node is unreachable for a specified timeout.
  • 1.5 behavior is to let the podGC clean up the pods after node deletion by NC.

Due to the fact that the deletion responsibility is now (as of 1.5) split
between the NC and podGC, we need an additional sleep to ensure that
things get cleaned up.

This was changed in #35235

@foxish
Fixing node-resize test to add a sleep.
a3d1466 
The new 1.5 behavior is to let the podGC clean up the pods.
The old pre-1.5 behavior is that the node controller force deletes
pods and the nodes once it detects that the node is unreachable.

The fact that the deletion responsibilty is now (as of 1.5) split
between the NC and podGC, we need an additional sleep to ensure that
things get cleaned up. The sleep is a NOP for the 1.3
test.
@foxish foxish added this to the v1.4 milestone Dec 7, 2016
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 7, 2016
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Dec 7, 2016
@jessfraz
Copy link
Contributor

jessfraz commented Dec 7, 2016

all green merging

@jessfraz jessfraz merged commit e8a12fa into kubernetes:release-1.4 Dec 7, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@dashpole dashpole mentioned this pull request Dec 8, 2016
Closed
@foxish foxish mentioned this pull request Dec 9, 2016
Closed
@foxish foxish deleted the fix-node-resize-1.4 branch December 9, 2016 22:36
@foxish foxish mentioned this pull request Dec 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jessfraz jessfraz

@saad-ali saad-ali

Labels
area/upgrade cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@foxish @k8s-reviewable @jessfraz @k8s-cherrypick-bot @saad-ali @k8s-github-robot @k8s-ci-robot